tikv: add flow-control config override hint by Connor1996 · Pull Request #9115 · pingcap/docs-cn

Connor1996 · 2022-04-22T07:33:31Z

Signed-off-by: Connor1996 zbk602423539@gmail.com

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add flow-control config override hint

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): config: override rocksdb config when flow control enabled tikv/tikv#11840

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

ti-chi-bot · 2022-04-22T07:33:32Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

en-jin19
qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

qiancai

LGTM

en-jin19 · 2022-04-25T09:20:54Z

tikv-configuration-file.md

 ### `memtables-threshold`

-+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。
+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).max-write-buffer-number`。


Suggested change

+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).max-write-buffer-number`。

+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).max-write-buffer-number` 的配置。

en-jin19 · 2022-04-25T09:21:17Z

tikv-configuration-file.md

 ### `l0-files-threshold`

-+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。
+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).level0-slowdown-writes-trigger`。


Suggested change

+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).level0-slowdown-writes-trigger`。

+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).level0-slowdown-writes-trigger` 的配置。

en-jin19 · 2022-04-25T09:21:38Z

tikv-configuration-file.md

 ### `soft-pending-compaction-bytes-limit`

-+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。
+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).soft-pending-compaction-bytes-limit`。


Suggested change

+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).soft-pending-compaction-bytes-limit`。

+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).soft-pending-compaction-bytes-limit` 的配置。

en-jin19 · 2022-04-25T09:21:51Z

tikv-configuration-file.md

 ### `hard-pending-compaction-bytes-limit`

-+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制拒绝所有写入请求，报错 `ServerIsBusy`。
+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制拒绝所有写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).hard-pending-compaction-bytes-limit`。


Suggested change

+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制拒绝所有写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).hard-pending-compaction-bytes-limit`。

+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制拒绝所有写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf|writecf|lockcf).hard-pending-compaction-bytes-limit` 的配置。

en-jin19 · 2022-04-25T09:23:50Z

@Connor1996 PTAL, thanks!

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

en-jin19

LGTM

en-jin19 · 2022-04-26T06:01:42Z

/verify

en-jin19 · 2022-04-26T06:34:14Z

/merge

ti-chi-bot · 2022-04-26T06:34:17Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 13de5b8

ti-chi-bot · 2022-04-26T06:35:28Z

In response to a cherrypick label: new pull request created: #9184.

ti-chi-bot · 2022-04-26T06:36:07Z

In response to a cherrypick label: new pull request created: #9185.

ti-chi-bot · 2022-04-26T06:36:45Z

In response to a cherrypick label: new pull request created: #9186.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-04-26T06:37:23Z

In response to a cherrypick label: new pull request created: #9187.

add config override hint

700503f

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

ti-chi-bot requested a review from TomShawn April 22, 2022 07:33

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2022

Connor1996 requested a review from tabokie April 22, 2022 07:33

Connor1996 mentioned this pull request Apr 22, 2022

config: override rocksdb config when flow control enabled tikv/tikv#11840

Merged

tabokie approved these changes Apr 22, 2022

View reviewed changes

shichun-0415 assigned en-jin19 Apr 24, 2022

shichun-0415 requested review from en-jin19 and removed request for TomShawn April 24, 2022 02:51

TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Apr 25, 2022

address comment

5c78832

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

qiancai approved these changes Apr 25, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022

en-jin19 reviewed Apr 25, 2022

View reviewed changes

address comment

13de5b8

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

en-jin19 approved these changes Apr 25, 2022

View reviewed changes

ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022

ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 25, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022

ti-chi-bot merged commit 9c118a7 into pingcap:master Apr 26, 2022

ti-chi-bot mentioned this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) #9184

Merged

17 tasks

ti-chi-bot mentioned this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) #9185

Merged

17 tasks

ti-chi-bot mentioned this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) #9186

Merged

17 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 26, 2022

This is an automated cherry-pick of pingcap#9115

7a21cc3

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) #9187

Merged

17 tasks

en-jin19 mentioned this pull request Apr 26, 2022

TiKV Config: add override information about some configuration items pingcap/docs#8375

Merged

17 tasks

en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 26, 2022

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) (#9185)

76cf464

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) (#9184)

1c5e200

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) (#9186)

b3581e1

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022

tikv: add flow-control config override hint (#9115) (#9187)

e45b9a1

	+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).max-write-buffer-number`。
	+ 当 KvDB 的 memtable 的个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).max-write-buffer-number` 的配置。

	+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).level0-slowdown-writes-trigger`。
	+ 当 KvDB 的 L0 文件个数达到该阈值时，流控机制开始工作。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).level0-slowdown-writes-trigger` 的配置。

	+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).soft-pending-compaction-bytes-limit`。
	+ 当 KvDB 的 pending compaction bytes 达到该阈值时，流控机制开始拒绝部分写入请求，报错 `ServerIsBusy`。当 `enable` 的值为 `true` 时，会覆盖 `rocksdb.(defaultcf\|writecf\|lockcf).soft-pending-compaction-bytes-limit` 的配置。

Conversation

Connor1996 commented Apr 22, 2022 • edited by en-jin19 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Apr 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiancai left a comment

Choose a reason for hiding this comment

Uh oh!

en-jin19 Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

en-jin19 Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

en-jin19 Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

en-jin19 Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

en-jin19 commented Apr 25, 2022

Uh oh!

en-jin19 left a comment

Choose a reason for hiding this comment

Uh oh!

en-jin19 commented Apr 26, 2022

Uh oh!

en-jin19 commented Apr 26, 2022

Uh oh!

ti-chi-bot commented Apr 26, 2022

Uh oh!

ti-chi-bot commented Apr 26, 2022

Uh oh!

ti-chi-bot commented Apr 26, 2022

Uh oh!

ti-chi-bot commented Apr 26, 2022

Uh oh!

ti-chi-bot commented Apr 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Connor1996 commented Apr 22, 2022 •

edited by en-jin19

Loading

ti-chi-bot commented Apr 22, 2022 •

edited

Loading

en-jin19 Apr 25, 2022 •

edited

Loading

en-jin19 Apr 25, 2022 •

edited

Loading

en-jin19 Apr 25, 2022 •

edited

Loading

en-jin19 Apr 25, 2022 •

edited

Loading