Skip to content

Synchronise the syntax tree of drop stats#11986

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
YangKeao:drop-multiple-stats
Jan 16, 2023
Merged

Synchronise the syntax tree of drop stats#11986
ti-chi-bot merged 1 commit intopingcap:masterfrom
YangKeao:drop-multiple-stats

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 14, 2022 •
edited
Loading

Signed-off-by: YangKeao yangkeao@chunibyo.icu

First-time contributors' checklist

What is changed, added or deleted? (Required)

I synchronize the syntax tree of drop stats with the newest one. It has two changes:

  1. Allow drop the stats of multiple tables at the same time.

The DROP STATS ... PARTITION ... and DROP STATS ... GLOBAL syntax are deprecated, so I didn't update them to documents.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 14, 2022 06:25
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2022
This was referenced Nov 14, 2022
Merged
Merged
@TomShawn TomShawn requested review from mjonss and xhebox November 14, 2022 06:49
@TomShawn TomShawn assigned TomShawn and unassigned TomShawn Nov 14, 2022
mjonss
mjonss reviewed Nov 14, 2022
View reviewed changes
@YangKeao
synchronise the syntax tree with drop stats
8d64b68 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the drop-multiple-stats branch from 9c90af3 to 8d64b68 Compare November 14, 2022 09:56
mjonss
mjonss approved these changes Nov 14, 2022
View reviewed changes
Copy link

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 14, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Nov 16, 2022

@YangKeao Hi, is this related to a feature or improvement to be released in v6.5?

@YangKeao
Copy link
Member Author

YangKeao commented Nov 17, 2022

@YangKeao Hi, is this related to a feature or improvement to be released in v6.5?

No

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 16, 2023
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 16, 2023
@shichun-0415
Copy link
Contributor

shichun-0415 commented Jan 16, 2023

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 16, 2023
@shichun-0415
Copy link
Contributor

shichun-0415 commented Jan 16, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8d64b68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 16, 2023
@ti-chi-bot ti-chi-bot merged commit 2102de1 into pingcap:master Jan 16, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #12675.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2023
Merged
15 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2023
Merged
15 tasks
ti-chi-bot added a commit that referenced this pull request Jan 16, 2023
@ti-chi-bot
Synchronise the syntax tree of drop stats (#11986) (#12675)
cfb1d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@mjonss mjonss mjonss approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YangKeao @ti-chi-bot @TomShawn @shichun-0415 @xhebox @mjonss