tools: update the usage of region startkey to region keys by IcePigZDB · Pull Request #6951 · pingcap/docs

IcePigZDB · 2021-11-23T12:54:42Z

Signed-off-by: IcePigZDB icepigzdb@gmail.com

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Support endKey in http interface regions/key and adjust the pdctl region command region startKey to region keysaccordingly. This is originally proposed as a precondition of the push down optimisation of infomation_schema.tikv_region_status.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from: tools: update the usage of region startkey to region keys docs-cn#7637
Other reference link(s):
- tracking issue: api,pd-ctl: support endKey in ScanRegions http interface tikv/pd#4400

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-11-23T12:54:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ref #tikv/pd/issues/4400 Signed-off-by: IcePigZDB <icepigzdb@gmail.com> Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

IcePigZDB · 2021-11-29T13:43:05Z

/cc @TomShawn

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

IcePigZDB · 2022-03-09T12:56:56Z

@TomShawn All comments have been resolved. PR tikv/pd/pull/4674 change the default value of limit with EndKey to 16 too. I have open the corresponding Chinese document modification PR pingcap/docs-cn/pull/8607 , I will open the English version after thie PR merged and notify you, thanks very much.

TomShawn · 2022-03-10T08:56:36Z

@TomShawn All comments have been resolved. PR tikv/pd/pull/4674 change the default value of limit with EndKey to 16 too. I have open the corresponding Chinese document modification PR pingcap/docs-cn/pull/8607 , I will open the English version after thie PR merged and notify you, thanks very much.

Thanks! If the default value of limit with EndKey is changed to 16, maybe you can change the value right in this PR after the docs-cn PR 8670 is merged.

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

IcePigZDB · 2022-03-10T09:17:13Z

@TomShawn All comments have been resolved. PR tikv/pd/pull/4674 change the default value of limit with EndKey to 16 too. I have open the corresponding Chinese document modification PR pingcap/docs-cn/pull/8607 , I will open the English version after thie PR merged and notify you, thanks very much.

Thanks! If the default value of limit with EndKey is changed to 16, maybe you can change the value right in this PR after the docs-cn PR 8670 is merged.

Done.

TomShawn · 2022-03-10T11:18:34Z

@IcePigZDB pingcap/docs-cn#8607 has been merged. Please sync it to this PR. Thanks!

IcePigZDB · 2022-03-10T12:17:38Z

@IcePigZDB pingcap/docs-cn#8607 has been merged. Please sync it to this PR. Thanks!

I checked again. It's synchronized in previous commit.

TomShawn

Rest LGTM

pd-control.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2022-05-13T04:09:48Z

/merge

ti-chi-bot · 2022-05-13T04:09:50Z

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2022-05-13T04:10:07Z

/remove-status LGT1
/status LGT2

TomShawn · 2022-05-13T04:10:12Z

/merge

ti-chi-bot · 2022-05-13T04:10:15Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: c3830a3

ti-chi-bot · 2022-05-13T04:11:14Z

In response to a cherrypick label: new pull request created: #8611.

ti-chi-bot · 2022-05-13T04:11:52Z

In response to a cherrypick label: new pull request created: #8612.

)

ti-chi-bot requested a review from TomShawn November 23, 2021 12:54

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2021

This was referenced Nov 23, 2021

Push down optimisation of TIKV_REGION_STATUS and TiKV_REGION_PEERS pingcap/tidb#28330

Open

api,pd-ctl: support endKey in ScanRegions http interface tikv/pd#4400

Open

tools: update the usage of region startkey to region keys

1b3a71c

ref #tikv/pd/issues/4400 Signed-off-by: IcePigZDB <icepigzdb@gmail.com> Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

IcePigZDB force-pushed the pdctl-regions-keys branch from 3dc1e17 to 1b3a71c Compare November 29, 2021 09:31

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2021

IcePigZDB added 9 commits November 29, 2021 17:33

tools: foramte region keys

7fbb829

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: foramte region keys

1a480fe

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: update region keys

30d9f36

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: formate

b1e7260

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: formate

50df645

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: formate

80a5204

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: formate

8174189

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: foramte

e24f4dd

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

tools: update

b76b525

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

IcePigZDB marked this pull request as ready for review November 29, 2021 13:25

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021

IcePigZDB mentioned this pull request Nov 29, 2021

tools: update the usage of region startkey to region keys pingcap/docs-cn#7637

Merged

15 tasks

IcePigZDB and others added 2 commits March 9, 2022 18:35

Update pd-control.md

fe44edb

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update pd-control.md

c038137

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 10, 2022

tools: update region keys default limit hint

4870307

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>

TomShawn approved these changes Apr 12, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022

TomShawn reviewed Apr 12, 2022

View reviewed changes

pd-control.md Outdated Show resolved Hide resolved

Update pd-control.md

c3830a3

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn added the needs-cherry-pick-release-6.0 label May 13, 2022

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022

ti-chi-bot merged commit 7c8cbf1 into pingcap:master May 13, 2022

ti-chi-bot mentioned this pull request May 13, 2022

tools: update the usage of region startkey to region keys (#6951) #8611

Merged

15 tasks

ti-chi-bot mentioned this pull request May 13, 2022

tools: update the usage of region startkey to region keys (#6951) #8612

Merged

15 tasks

ti-chi-bot added a commit that referenced this pull request May 13, 2022

tools: update the usage of region startkey to region keys (#6951) (#8612

0617789

)

ti-chi-bot added a commit that referenced this pull request May 13, 2022

tools: update the usage of region startkey to region keys (#6951) (#8611

e813809

)

IcePigZDB deleted the pdctl-regions-keys branch May 13, 2022 08:51

Conversation

IcePigZDB commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IcePigZDB commented Nov 29, 2021

Uh oh!

IcePigZDB commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IcePigZDB commented Mar 10, 2022

Uh oh!

TomShawn commented Mar 10, 2022

Uh oh!

IcePigZDB commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomShawn commented May 13, 2022

Uh oh!

ti-chi-bot commented May 13, 2022

Uh oh!

TomShawn commented May 13, 2022

Uh oh!

TomShawn commented May 13, 2022

Uh oh!

ti-chi-bot commented May 13, 2022

Uh oh!

ti-chi-bot commented May 13, 2022

Uh oh!

ti-chi-bot commented May 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

IcePigZDB commented Nov 23, 2021 •

edited

Loading

ti-chi-bot commented Nov 23, 2021 •

edited

Loading

IcePigZDB commented Mar 9, 2022 •

edited

Loading

TomShawn commented Mar 10, 2022 •

edited

Loading

IcePigZDB commented Mar 10, 2022 •

edited

Loading