add decode and load meta command#80
add decode and load meta command#803pointer wants to merge 2 commits intopingcap:masterfrom 3pointer:debug_backupmeta
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 66.75% 65.71% -1.04%
==========================================
Files 22 22
Lines 2644 2701 +57
==========================================
+ Hits 1765 1775 +10
- Misses 642 687 +45
- Partials 237 239 +2
Continue to review full report at Codecov.
|
|
What do you think the better cmd name? I prefer |
|
Or maybe just store the backupmeta as JSON instead of protobuf so we don't need this command 😝 |
Good idea! cc @3pointer @overvenus |
|
Let's keep protobuf format for production, JSON number makes me uncomfortable. :-/ I think this command is good enough for debug/hotfix purposes. |
| return nil | ||
| }, | ||
| } | ||
| meta.AddCommand(decodeBackupMetaCmd) |
There was a problem hiding this comment.
Could you test it in the integration tests? It can improve code coverage.
| return nil | ||
| }, | ||
| } | ||
| meta.AddCommand(loadBackupMetaCmd) |
There was a problem hiding this comment.
Could you test it in the integration tests? It can improve code coverage.
Co-Authored-By: Neil Shen <overvenus@gmail.com>
|
|
||
| loadBackupMetaCmd := &cobra.Command{ | ||
| Use: "encode", | ||
| Short: "load backupmeta json file to backupmeta", |
There was a problem hiding this comment.
| Short: "load backupmeta json file to backupmeta", | |
| Short: "encode backupmeta json file to backupmeta", |
No description provided.