This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Closed
Conversation
a3e3797 to
55751d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
========================================
- Coverage 73.31% 71% -2.31%
========================================
Files 30 30
Lines 2908 2766 -142
========================================
- Hits 2132 1964 -168
- Misses 474 528 +54
+ Partials 302 274 -28
Continue to review full report at Codecov.
|
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
55751d3 to
9ae799b
Compare
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
09c9797 to
96b9f98
Compare
Contributor
Author
|
/run-integration-test |
overvenus
reviewed
Dec 4, 2019
Comment on lines
+196
to
+197
| // Simulate to create table | ||
| for _, table := range tables { |
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
3pointer
reviewed
Dec 12, 2019
| calculated sha256 is %s, | ||
| origin sha256 is %s`, file.Name, hex.EncodeToString(s[:]), hex.EncodeToString(file.Sha256)) | ||
| } | ||
| log.Info("table info", zap.Stringer("table", tblInfo.Name), |
Collaborator
There was a problem hiding this comment.
move this log out of for _, schema := range backupMeta.Schemas loop?
overvenus
approved these changes
Dec 12, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers tangminghua@pingcap.com