Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

backup: support set compression level for sst file#451

Merged
overvenus merged 10 commits intopingcap:masterfrom
glorv:compress-level
Aug 11, 2020
Merged

backup: support set compression level for sst file#451
overvenus merged 10 commits intopingcap:masterfrom
glorv:compress-level

Conversation

@glorv
Copy link
Collaborator

@glorv glorv commented Aug 7, 2020

What problem does this PR solve?

Support compression level config when generate sst files.

What is changed and how it works?

Add a command line parameter for compression level

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported variable/fields change

Side effects

Related changes

  • Need to cherry-pick to release-4.0
  • Need to update the documentation

Release Note

  • Add a parameter --compression-level to support compression level for sst file

@glorv glorv requested review from 3pointer, YuJuncen and kennytm August 7, 2020 02:21
@glorv
Copy link
Collaborator Author

glorv commented Aug 7, 2020

should update tidb to the newest kvproto first

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 7, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a test in br_other to improve code coverage.

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Aug 10, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Aug 10, 2020
@glorv
Copy link
Collaborator Author

glorv commented Aug 10, 2020

/run-all-tests

2 similar comments
@glorv
Copy link
Collaborator Author

glorv commented Aug 10, 2020

/run-all-tests

@glorv
Copy link
Collaborator Author

glorv commented Aug 11, 2020

/run-all-tests

@overvenus overvenus merged commit 74ea409 into pingcap:master Aug 11, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

glorv added a commit to glorv/br that referenced this pull request Aug 17, 2020
kennytm pushed a commit that referenced this pull request Aug 20, 2020
* backup: support set compression level for sst file (#451)

* fix mock cluster

* fix tests

* fix tests

* fix go.sum

* fix go.sum

* fix test

* update multi-statements

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@glorv glorv deleted the compress-level branch April 8, 2021 04:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants