This repository was archived by the owner on Jul 24, 2024. It is now read-only.
conn: set PD timeout to 10 secs#432
Merged
ti-srebot merged 5 commits intopingcap:masterfrom Jul 22, 2020
Merged
Conversation
10 secs (comparing to 3 secs, the default value) seems is enough for many scenarios. Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Collaborator
Author
|
For 4.0 version, waiting for pingcap/tidb#18570. |
Collaborator
Author
|
/build |
overvenus
approved these changes
Jul 22, 2020
Member
overvenus
left a comment
There was a problem hiding this comment.
LGTM, we can update pd in tidb when we update br in tidb.
ti-srebot
approved these changes
Jul 22, 2020
Collaborator
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #324
What is changed and how it works?
github.com/pingcap/pd/v4 v4.0.0-rc.2.0.20200714122454-1a64f969cb3c.So, we can...
github.com/pingcap/tidb v1.1.0-beta.0.20200721005019-f5c6e59f0daf.And use the new API to set timeout.
Check List
Tests
Since this is the internal part of PD client, we cannot add unit tests by injecting fail point. Thanks for that it's a really small change.
Release Note