Closed
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
This was referenced Jul 21, 2020
Member
Author
|
This PR is outdated. Close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: see tikv/pd#2642.
Problem Summary: When creating TSO stream, If the server crashes, it may have a possibility that blocks for a while until TCP layer timeout.
What is changed and how it works?
What's Changed: Add a context check mechanism when creating TSO stream.
How it Works: Use an extra goroutine to check if the context is timeout.
Release note