This repository was archived by the owner on Jul 24, 2024. It is now read-only.
restore: make split and restore pipelined.#427
Merged
ti-srebot merged 36 commits intopingcap:masterfrom Oct 9, 2020
Merged
Conversation
added 2 commits
July 16, 2020 18:59
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Collaborator
Author
|
/build |
Collaborator
Author
|
/run-integration-test |
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
remove reject stores sometime always grow too huge and provides little useful information, move it to DEBUG. add a log when any file is fully restored, which is useful troubleshooting when some restore goes slow. Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
3pointer
reviewed
Jul 20, 2020
added 2 commits
July 20, 2020 17:26
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
3pointer
reviewed
Jul 20, 2020
…hen exit Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Collaborator
Author
|
/run-integration-test
|
Collaborator
Author
|
/run-integration-test |
Collaborator
Author
|
Seems it's buggy, will it reproduce again?
/run-integration-test |
Collaborator
|
It's green now. |
kennytm
reviewed
Sep 18, 2020
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Collaborator
Author
|
/run-integration-test |
Collaborator
Author
/run-integration-test 🤔 |
Collaborator
Author
|
/run-integration-test |
3pointer
reviewed
Oct 9, 2020
pkg/restore/import.go
Outdated
| return errIngest | ||
| } | ||
| summary.CollectSuccessUnit(summary.TotalKV, 1, file.TotalKvs) | ||
| summary.CollectSuccessUnit(summary.TotalBytes, 1, file.TotalBytes) |
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Collaborator
|
LGTM |
ti-srebot
approved these changes
Oct 9, 2020
Collaborator
Author
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-4.0 failed |
YuJuncen
added a commit
to YuJuncen/br
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
YuJuncen
added a commit
that referenced
this pull request
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hillium maruruku@stu.csust.edu.cn
What problem does this PR solve?
Fix #419
What is changed and how it works?
We changed the interface of
BatchSender, so it can run asynchronously:Then, we must change the call site of
Batcher, and make another goroutine(known ascontextCleaner) to accept tables that restored asynchronously, do the clean job, and send tables to next.(TODO?: since the sender can be internally asynchronous, we can remove
sendWorkerand send requests directly at the call site. However the risk of this is that the channel size ofBatchSendermight block the caller, and we must pass actxto methods likeAddsinceContextManagerneed to be in the tree of structured concurrent too.)Check List
Tests
Internal test: real time 12m28s -> 9m5s (45000+ ranges)
Release Note