This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Fix speed compute (#1408)#1412
Merged
ti-chi-bot merged 3 commits intopingcap:release-5.1from Sep 13, 2021
Merged
Conversation
Try to fix the average-speed for backup/restore
remove the useless code
Member
Author
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Merged
YuJuncen
approved these changes
Aug 4, 2021
kennytm
approved these changes
Aug 9, 2021
Collaborator
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: fce05a7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1408
What problem does this PR solve?
fix issue: the average speed isn't accurate(#1405)
What is changed and how it works?
change the Calculation method for speed
Check List
Tests
command
./br backup full --pd "172.16.6.117:2379" --compression-level 3 --storage "local:///home/zak/new_br"
./br restore full --pd "172.16.6.117:2379" --storage "local:///home/zak/new_br"
log
[2021/08/04 10:03:34.913 +08:00] [INFO] [collector.go:67] ["Full backup success summary"] [total-ranges=45] [ranges-succeed=45] [ranges-failed=0] [backup-checksum=3.515718214s] [backup-fast-checksum=7.003603ms] [backup-total-ranges=58] [backup-total-regions=77] [total-take=14.017946255s] [total-kv=15463846] [total-kv-size=1.859GB] [average-speed=132.6MB/s] ["backup data size(after compressed)"=496.8MB] [BackupTS=426781599562989570]
[2021/08/04 10:06:45.055 +08:00] [INFO] [collector.go:67] ["Full restore success summary"] [total-ranges=37] [ranges-succeed=37] [ranges-failed=0] [split-region=362.373805ms] [restore-checksum=6.890396086s] [restore-ranges=29] [total-take=17.328491842s] ["restore data size(after compressed)"=496.7MB] [total-kv=15462460] [total-kv-size=1.858GB] [average-speed=107.2MB/s]
Release note
backupandrestore