Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

flags: hidden not stable command flags#133

Merged
overvenus merged 2 commits intomasterfrom
hidden_flags
Jan 3, 2020
Merged

flags: hidden not stable command flags#133
overvenus merged 2 commits intomasterfrom
hidden_flags

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented Jan 3, 2020

No description provided.

@3pointer 3pointer requested a review from overvenus January 3, 2020 02:20
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #133 into master will decrease coverage by 1.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   74.08%   72.97%   -1.12%     
==========================================
  Files          35       33       -2     
  Lines        3886     3234     -652     
==========================================
- Hits         2879     2360     -519     
+ Misses        683      585      -98     
+ Partials      324      289      -35
Impacted Files Coverage Δ
cmd/validate.go 67.62% <100%> (+0.13%) ⬆️
pkg/storage/gcs.go 71.96% <100%> (+0.8%) ⬆️
pkg/storage/s3.go 84.41% <100%> (+0.63%) ⬆️
cmd/backup.go 67.97% <100%> (-2.71%) ⬇️
pkg/restore/import.go 64.55% <0%> (-8.9%) ⬇️
pkg/backup/client.go 73.47% <0%> (-6.11%) ⬇️
cmd/restore.go 64.34% <0%> (-2.68%) ⬇️
pkg/restore/client.go 72.9% <0%> (-1.24%) ⬇️
pkg/utils/keys.go
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f72a1...25403b4. Read the comment docs.

@overvenus
Copy link
Member

Could you hidden validate subcommand too?

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus merged commit 124d821 into master Jan 3, 2020
@overvenus overvenus deleted the hidden_flags branch January 3, 2020 03:16
overvenus pushed a commit to overvenus/br-1 that referenced this pull request Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants