Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

restore: Fix restore data size#1285

Merged
ti-chi-bot merged 17 commits intopingcap:masterfrom
ZipFast:fix-restore-data-size
Jul 6, 2021
Merged

restore: Fix restore data size#1285
ti-chi-bot merged 17 commits intopingcap:masterfrom
ZipFast:fix-restore-data-size

Conversation

@ZipFast
Copy link
Contributor

@ZipFast ZipFast commented Jun 25, 2021 •
edited
Loading

What problem does this PR solve?

close issue #1270
The previous summary field restore data size(after compressed) is not correct and will count the files that will not be restored. This pr solve this problem.

What is changed and how it works?

Add filter in size account

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No Release Note

@ti-chi-bot ti-chi-bot requested review from 3pointer and overvenus June 25, 2021 06:41
@ZipFast ZipFast linked an issue Jun 25, 2021 that may be closed by this pull request
br restore statistics not correct if restore with -f parameters #1270
Closed
3pointer
3pointer reviewed Jun 25, 2021
View reviewed changes
YuJuncen
YuJuncen reviewed Jun 25, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Jun 28, 2021
@ZipFast ZipFast force-pushed the fix-restore-data-size branch from 567229f to 1ce78d6 Compare June 28, 2021 03:52
@ti-chi-bot ti-chi-bot added size/S and removed size/M labels Jun 28, 2021
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Jun 28, 2021
YuJuncen
YuJuncen reviewed Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, and if possible, could you add an unit test for reader.ArchiveSize method?

@ZipFast
Copy link
Contributor Author

ZipFast commented Jun 30, 2021

/run-integration-test

3pointer
3pointer reviewed Jul 1, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jul 2, 2021
YuJuncen
YuJuncen reviewed Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

YuJuncen
YuJuncen approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 2, 2021
@ti-chi-bot ti-chi-bot added size/M and removed size/L labels Jul 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 6, 2021
@3pointer
Copy link
Collaborator

3pointer commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4a87b92

@ti-chi-bot ti-chi-bot merged commit df27ac2 into pingcap:master Jul 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2021
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2021

In response to a cherrypick label: new pull request created: #1319.

ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
@ti-chi-bot
restore: Fix restore data size (#1285) (#1319)
649f3ca
@ZipFast ZipFast mentioned this pull request Jul 19, 2021
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2021
Merged
This was referenced Jul 27, 2021
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@overvenus overvenus Awaiting requested review from overvenus

2 more reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/restore needs-cherry-pick-release-5.1 size/M status/can-merge status/LGT2 LGTM2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

br restore statistics not correct if restore with -f parameters

5 participants

@ZipFast @ti-chi-bot @3pointer @YuJuncen @Relax4Life