This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
======================================
Coverage 73.2% 73.2%
======================================
Files 33 33
Lines 3284 3284
======================================
Hits 2404 2404
Misses 581 581
Partials 299 299Continue to review full report at Codecov.
|
kennytm
reviewed
Dec 24, 2019
Collaborator
kennytm
left a comment
There was a problem hiding this comment.
Rest LGTM.
Could we do something for the coverage?
| run_br validate encode -s "local://$TEST_DIR/$DB" | ||
|
|
||
| # should generate backupmeta_from_json | ||
| if [ ! -f "$TEST_DIR/$DB/backupmeta_from_json" ]; then |
Collaborator
There was a problem hiding this comment.
we should compare backupmeta and backupmeta_from_json are the same file (diff them)?
Collaborator
Author
let me try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#80 is broken after BR project open source