restore: auto remove/add pd scheduler in restore#123
restore: auto remove/add pd scheduler in restore#123overvenus merged 7 commits intopingcap:masterfrom
Conversation
96cdc05 to
fb1ed17
Compare
|
/run-all-tests |
4 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 33 33
Lines 3483 3483
=======================================
Hits 2571 2571
Misses 589 589
Partials 323 323Continue to review full report at Codecov.
|
kennytm
left a comment
There was a problem hiding this comment.
Rest LGTM.
Are the schedulers still removed even in online import mode?
| } | ||
| ctx, cancel := context.WithCancel(GetDefaultContext()) | ||
| defer cancel() | ||
| func runRestore(flagSet *flag.FlagSet, cmdName, dbName, tableName string) error { |
Sure, I think we should check is online in prepareWork |
| } | ||
|
|
||
| func addPDLeaderScheduler(ctx context.Context, mgr *conn.Mgr, removedSchedulers []string) error { | ||
| for _, scheduler := range removedSchedulers { |
There was a problem hiding this comment.
Question. Since map is randomly ordered, the schedulers are added in random order as well. Is this OK for PD?
There was a problem hiding this comment.
AFAIK, yes, there is no dependency problem between each scheduler.
No description provided.