Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

backup: check GC fail fast#119

Merged
overvenus merged 1 commit intomasterfrom
check-gc
Dec 18, 2019
Merged

backup: check GC fail fast#119
overvenus merged 1 commit intomasterfrom
check-gc

Conversation

@overvenus
Copy link
Member

Fail fast if the backup ts exceed GC safe point ts.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #119 into master will decrease coverage by 2.62%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   74.11%   71.49%   -2.63%     
==========================================
  Files          33       31       -2     
  Lines        3404     3031     -373     
==========================================
- Hits         2523     2167     -356     
+ Misses        580      577       -3     
+ Partials      301      287      -14
Impacted Files Coverage Δ
pkg/backup/client.go 71.11% <0%> (-3.46%) ⬇️
pkg/backup/safe_point.go 64.28% <0%> (-4.95%) ⬇️
cmd/restore.go 57.04% <0%> (-11.29%) ⬇️
cmd/backup.go 66.9% <0%> (-8.37%) ⬇️
pkg/restore/client.go 73.26% <0%> (-4.73%) ⬇️
pkg/summary/collector.go
pkg/summary/summary.go
pkg/restore/util.go 87.15% <0%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c6550...daf7b8c. Read the comment docs.

Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@5kbpers 5kbpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus merged commit 18f5421 into master Dec 18, 2019
@overvenus overvenus deleted the check-gc branch December 18, 2019 12:06
overvenus pushed a commit to overvenus/br-1 that referenced this pull request Dec 29, 2020
…rt` (pingcap#119)

* restore: resolve conflicts

* restore: do not do compact after engine file imported

* restore: address comment

* worker: panic if recycle a nil worker

* restore: resolve conflicts

* restore: init

* *: address comment

* *: address comment

* config: change default value of `level-1-compact`

Co-Authored-By: lonng <chris@lonng.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants