Review Checklist

• Target branch (11.5 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

Quality Gate passed

Issues
2 New issues
59 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
5.1% Duplication on New Code

See analysis details on SonarQube Cloud

Sonar complaints about the long lines (they were already too long before the change, though).
Do you want me to break them down into multiple lines?

Thank you for your PR!

Sonar complaints about the long lines (they were already too long before the change, though). Do you want me to break them down into multiple lines?

No need that 😉 i've marked them all as accepted for the moment, we (actually Herbert) had some idea to use tools like RectorPHP to automate this kind of coding standard work to polish all the legacy code.

Rector is a great tool! But I don't think it does any formatting. I usually run PHP-CS-Fixer after Rector to format the changed code. But I don't think PHP-CS-Fixer can do this kind of formatting (splitting long lines) either. You probably need something like Mago for that 🤔

@jdreesen @kingjia90 Rector alone will not do the Job. Rector is AST-based, not whitespace-aware, so it’s intentionally not meant for layout formatting. But Rector can help in a two step approach.

• Rector for structure
• PHP-CS-Fixer or ECS for wrapping
  I'm testing workflows that first improve readability by simplifying code and sometimes incidentally shorten long lines with rector and after this use PhpCsFixer for formatting, including line length.
  This is work in progress and there is no timeline for this. It's a side project :-)

Is there any chance that this will be considered for Pimcore 11.5.13?

Friendly ping.

The other PR (pimcore/ecommerce-framework-bundle#277) has already been merged.