Add support for condition variable types when using the Note Listing#9935
Merged
dvesh3 merged 1 commit intopimcore:10.1from Aug 9, 2021
Merged
Conversation
The Listing class for Notes did not take the condition variable types
into account when building the query. This made it impossible to perform
some advanced queries on the notes, such as using the IN() operator with
an array of strings.
Use case:
WHERE `type` IN ('erp_import', 'workflow')
Contributor
|
@samynw thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Previously the Listing class for Notes did not take the condition variable types into account when building the query. This made it impossible to perform some advanced queries on the notes, such as using the
IN(?)operator with an array of strings.Additional info
Example
Without the
conditionVariableTypesthe array of strings is not processed correctly when preparing the query.