[Task]: Require PHPStan v2.0#18034
Merged
kingjia90 merged 21 commits intopimcore:12.xfrom Feb 26, 2025
Merged
Conversation
Review Checklist
|
jdreesen
reviewed
Jan 28, 2025
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Merged
# Conflicts: # phpstan-baseline.neon
# Conflicts: # phpstan-baseline.neon # phpstan-parameters.neon
kingjia90
reviewed
Feb 18, 2025
Contributor
kingjia90
left a comment
There was a problem hiding this comment.
Thank you for your PR!
I went through a quick scan and found some points that may need some clarification, but the rest LGTM so far
bundles/XliffBundle/src/ExportDataExtractorService/DataExtractor/DocumentDataExtractor.php
Show resolved
Hide resolved
models/DataObject/ClassDefinition/Data/AdvancedManyToManyObjectRelation.php
Show resolved
Hide resolved
# Conflicts: # composer.json # lib/Image/HtmlToImage.php # lib/Workflow/Manager.php
Contributor
Author
|
@kingjia90 The PR would be smaller if you merge this PR first: #18042 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete PR of #17816