Conversation
Review Checklist
|
Contributor
Author
|
Might be depending on ergebnis/phpstan-rules#859 Update: a PR seems there ergebnis/phpstan-rules#873 |
|
Contributor
Author
|
It seems more strict now (instanceof checks, unused traits) and that there are many rules that were previously ignored or things like checking PHPDocs etc.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan v2 just got released, let's see if there's any breaking change
https://github.com/phpstan/phpstan/releases/tag/2.0.0