[Task] Move newsletter functionality to PimcoreNewsletterBundle#14848
Merged
[Task] Move newsletter functionality to PimcoreNewsletterBundle#14848
Conversation
Review Checklist
|
…-to-bundle # Conflicts: # bundles/NewsletterBundle/src/Model/Document/Newsletter.php
…-to-bundle # Conflicts: # bundles/CoreBundle/config/pimcore/default.yaml
dvesh3
reviewed
Apr 5, 2023
Contributor
dvesh3
left a comment
There was a problem hiding this comment.
Please see suggestions from first code scan. Also add migration to mark the bundle as installed on upgrade.
kingjia90
requested changes
Apr 5, 2023
Contributor
kingjia90
left a comment
There was a problem hiding this comment.
Just found these issues after an initial scan
bundles/NewsletterBundle/src/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
kingjia90
reviewed
Apr 5, 2023
bundles/NewsletterBundle/src/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
kingjia90
reviewed
Apr 5, 2023
This was referenced Apr 6, 2023
kingjia90
requested changes
Apr 6, 2023
Contributor
kingjia90
left a comment
There was a problem hiding this comment.
some further issues when testing, but so far works fine
bundles/NewsletterBundle/src/Document/Newsletter/AddressSourceAdapter/DefaultAdapter.php
Show resolved
Hide resolved
… into 14802-move-newsletter-to-bundle
kingjia90
reviewed
Apr 7, 2023
bundles/NewsletterBundle/src/Controller/Document/NewsletterController.php
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
kingjia90
reviewed
Apr 11, 2023
Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
dvesh3
added a commit
to pimcore/compatibility-bridge-v10
that referenced
this pull request
Apr 11, 2023
kingjia90
reviewed
Apr 11, 2023
kingjia90
reviewed
Apr 11, 2023
mattamon
pushed a commit
to pimcore/compatibility-bridge-v10
that referenced
this pull request
Apr 12, 2023
brusch
added a commit
to pimcore/customer-data-framework
that referenced
this pull request
Apr 12, 2023
brusch
added a commit
to pimcore/output-data-config-toolkit
that referenced
this pull request
Apr 12, 2023
brusch
added a commit
to pimcore/perspective-editor
that referenced
this pull request
Apr 12, 2023
brusch
added a commit
to pimcore/data-importer
that referenced
this pull request
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #14802
Additional info
Related to #14842 and #14844