Merged
Conversation
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
# Conflicts: # bundles/AdminBundle/public/js/pimcore/layout/toolbar.js # bundles/AdminBundle/templates/admin/index/index.html.twig # bundles/CoreBundle/src/DependencyInjection/PimcoreCoreExtension.php # bundles/GoogleMarketingBundle/public/js/report/analytics/elementexplorer.js # bundles/GoogleMarketingBundle/public/js/report/analytics/elementoverview.js # bundles/GoogleMarketingBundle/public/js/report/analytics/siteoverview.js # composer.json
dvesh3
reviewed
Feb 21, 2023
bundles/GoogleMarketingBundle/.github/ci/files/config/system.yml
Outdated
Show resolved
Hide resolved
bundles/GoogleMarketingBundle/public/js/report/analytics/siteoverview.js
Outdated
Show resolved
Hide resolved
Remove unnecessary use statements Update docs
dvesh3
reviewed
Feb 21, 2023
Contributor
dvesh3
left a comment
There was a problem hiding this comment.
Also, add:
- Migration to mark the bundle as installed and adding permissions.
- Upgrade notes for refactoring Marketing features & Removing Google CSE
bundles/EcommerceFrameworkBundle/src/Tracking/Tracker/Analytics/AbstractAnalyticsTracker.php
Show resolved
Hide resolved
# Conflicts: # bundles/GoogleMarketingBundle/docs/05_Analytics.md
….com/pimcore/pimcore into 12524-move-googlemarketing-to-bundle
dvesh3
approved these changes
Feb 22, 2023
kingjia90
previously approved these changes
Feb 22, 2023
wait, what happens to custom_report_adapter_analytics reports after one uninstall the googlemarketing bundle?
kingjia90
reviewed
Feb 22, 2023
Contributor
Contributor
Good catch! Added here 01cb843 |
brusch
added a commit
to pimcore/customer-data-framework
that referenced
this pull request
Feb 22, 2023
brusch
added a commit
to pimcore/perspective-editor
that referenced
this pull request
Feb 22, 2023
brusch
added a commit
to pimcore/data-hub
that referenced
this pull request
Feb 22, 2023
brusch
added a commit
to pimcore/data-importer
that referenced
this pull request
Feb 22, 2023
dvesh3
pushed a commit
to pimcore/customer-data-framework
that referenced
this pull request
Feb 22, 2023
mcop1
pushed a commit
to pimcore/data-importer
that referenced
this pull request
Feb 22, 2023
mcop1
pushed a commit
to pimcore/data-hub
that referenced
this pull request
Feb 22, 2023
mcop1
pushed a commit
to pimcore/perspective-editor
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #12524
Resolves #14279
Additional info
Moving google marketing functionality into PimcoreGoogleMarketingBundle
Able to install and uninstall via Installer. Permissions are in the Bundle
Moved translations into the bundle