Adding TypeLoader and type_definitions for documents#14047
Conversation
Review Checklist
|
Adding deprecation trigger
# Conflicts: # doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
fashxp
left a comment
There was a problem hiding this comment.
looks good to me now, but we should add a documentation similar to the ones for how to add editables
|
@fashxp we should also think about the getTypes method: https://github.com/pimcore/pimcore/blob/10.6/models/Document.php#L154 as it returns the predefined list here: https://github.com/pimcore/pimcore/blob/10.6/bundles/CoreBundle/Resources/config/pimcore/default.yaml#L203 Maybe we should switch to the keys of the mapping? |
good catch. yes we should, but that we only can do with Pimcore 11 ... removing a config option would be a BC break. |
* Adding TypeLoader and type_definitions for documents * Breaking Change Layer to enable custom document via config * Enable the loader by default Adding deprecation trigger * Update upgrade notes * Removing unnecessary imports * Add doc on how to add custom documents * Deprecating document types * Adding additional info to deprecation
* Adding TypeLoader and type_definitions for documents * Breaking Change Layer to enable custom document via config * Enable the loader by default Adding deprecation trigger * Update upgrade notes * Removing unnecessary imports * Add doc on how to add custom documents * Deprecating document types * Adding additional info to deprecation
* Adding TypeLoader and type_definitions for documents * Breaking Change Layer to enable custom document via config * Enable the loader by default Adding deprecation trigger * Update upgrade notes * Removing unnecessary imports * Add doc on how to add custom documents * Deprecating document types * Adding additional info to deprecation
Changes in this pull request
Resolves #13947
Additional info
Adding a TypeLoader instead of loading the Documents via namespace.
Making it possible to extend or override existing types