Merged
Conversation
Review Checklist
|
mattamon
suggested changes
Jan 10, 2023
Contributor
mattamon
left a comment
There was a problem hiding this comment.
Can you please check this changes according to the refactoring tips too?
Contributor
|
@aashan10 can you please merge in the latest 11.x updates, so the tests run trough again? |
mattamon
approved these changes
Jan 12, 2023
dvesh3
reviewed
Jan 13, 2023
dvesh3
reviewed
Jan 13, 2023
Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
dvesh3
suggested changes
Jan 13, 2023
Contributor
There was a problem hiding this comment.
-
Add core migration to mark the bundle installed.
-
Dao class mapping should be moved too
pimcore/config/dao-classmap.php
Lines 157 to 158 in 83142b5
-
Update docs that feature requires bundle to be installed
dvesh3
approved these changes
Jan 16, 2023
dvesh3
added a commit
to pimcore/customer-data-framework
that referenced
this pull request
Jan 16, 2023
dvesh3
added a commit
to pimcore/data-hub
that referenced
this pull request
Jan 16, 2023
dvesh3
added a commit
to pimcore/output-data-config-toolkit
that referenced
this pull request
Jan 16, 2023
dvesh3
added a commit
to pimcore/data-importer
that referenced
this pull request
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #12532
Additional info