Skip to content

Fix channel selection to not remove "time channel" #439

Merged
smoia merged 1 commit intophysiopy:masterfrom
smoia:fix/chselname
Feb 15, 2023
Merged

Fix channel selection to not remove "time channel" #439
smoia merged 1 commit intophysiopy:masterfrom
smoia:fix/chselname

Conversation

@smoia
Copy link
Copy Markdown
Member

@smoia smoia commented Feb 15, 2023

Closes #437

Fix the loop to delete information at indexes not included in specified channel selections by ignoring channel 0.

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Feb 15, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2023

Codecov Report

Merging #439 (c6ae189) into master (4464c84) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files           8        8           
  Lines         966      966           
=======================================
  Hits          916      916           
  Misses         50       50
Impacted Files Coverage Δ
phys2bids/phys2bids.py 90.10% <0.00%> (ø)

@smoia smoia mentioned this pull request Feb 15, 2023
Closed
@smoia smoia merged commit ba981ee into physiopy:master Feb 15, 2023
@smoia smoia deleted the fix/chselname branch February 15, 2023 22:15
@smoia
Copy link
Copy Markdown
Member Author

smoia commented Feb 15, 2023

🚀 PR was released in 2.8.1 🚀

@smoia smoia added the released This issue/pull request has been released. label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) released This issue/pull request has been released.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

selecting channels results in incorrect json

1 participant

@smoia