Skip to content

selecting channels results in incorrect json #437

@sdwilli123

Description

@sdwilli123

selecting a subset of channels with the -chselect flag creates the correct .tsv file but the accompanying .json file is incorrect and doesn't have a matching number of channels when given custom names ('time' overwrites the first name).

Expected Behavior

selecting 3 channels ( eg. -chselect 1 3 4) and feeding in 3 custom channel labels (-chnames 'breath' 'pulse' 'triggers' ) would ideally result in only 3 channel labels in the .json file but it does not

Actual Behavior

only 2 of the custom channel labels are showing up in the .json file instead of all 3
"Columns": [
"time",
"breath",
"pulse"
]
e.g.
You can see here that 'time' has been inserted in the .json even though it wasn't specified in the custom channel name list ... not sure where it's coming from

example command:
phys2bids -in ${fname} -indir ${inp} -outdir ${outp} -heur ${p}/scripts/bidsphysio_heurv2.py -sub 01 -chnames 'Breath' 'Pulse' 'Triggers' -chsel 1 3 4

Steps to Reproduce the Problem

1.
2.
3.

Specifications

- Python version: 
- phys2bids version:
- Platform:

Possible solution

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingreleasedThis issue/pull request has been released.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions