Skip to content

Fix trigger index update on channel subset selection (-chsel)#433

Merged
smoia merged 2 commits intophysiopy:masterfrom
smoia:fix/chtrig
Mar 14, 2023
Merged

Fix trigger index update on channel subset selection (-chsel)#433
smoia merged 2 commits intophysiopy:masterfrom
smoia:fix/chtrig

Conversation

@smoia
Copy link
Copy Markdown
Member

@smoia smoia commented Dec 14, 2022

Closes none but references #431

This PR Fixes the use of trigger indexes.

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Dec 14, 2022
@smoia smoia mentioned this pull request Dec 14, 2022
Closed
@smoia
Copy link
Copy Markdown
Member Author

smoia commented Dec 15, 2022

@dangom would you be able to test this branch on your file(s)?
And/or would you be ok to add your file (a part of it) to our OSF library of tests?

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2022 •
edited
Loading

Codecov Report

Merging #433 (6571e6b) into master (06ba771) will decrease coverage by 0.49%.
The diff coverage is 50.00%.

❗ Current head 6571e6b differs from pull request most recent head 75b57d6. Consider uploading reports for the commit 75b57d6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   94.83%   94.35%   -0.49%     
==========================================
  Files           8        8              
  Lines         968      885      -83     
==========================================
- Hits          918      835      -83     
  Misses         50       50
Impacted Files Coverage Δ
phys2bids/phys2bids.py 85.71% <50.00%> (-4.40%) ⬇️

... and 3 files with indirect coverage changes

@smoia smoia merged commit d5d8f9c into physiopy:master Mar 14, 2023
@smoia smoia deleted the fix/chtrig branch March 14, 2023 16:23
@smoia
Copy link
Copy Markdown
Member Author

smoia commented Mar 14, 2023

🚀 PR was released in 2.8.3 🚀

@smoia smoia added the released This issue/pull request has been released. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) released This issue/pull request has been released.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smoia