Skip to content

Let runfiles env vars take priority#2

Merged
phst merged 1 commit intophst:masterfrom
fmeum:use-vars-first
Jan 17, 2022
Merged

Let runfiles env vars take priority#2
phst merged 1 commit intophst:masterfrom
fmeum:use-vars-first

Conversation

@fmeum
Copy link
Copy Markdown
Contributor

@fmeum fmeum commented Dec 30, 2021

@phst
Copy link
Copy Markdown
Owner

phst commented Dec 30, 2021

I agree that this is the better choice, but I think we should try to fix https://docs.google.com/document/d/e/2PACX-1vSDIrFnFvEYhKsCMdGdD40wZRBX3m3aZ5HhVj4CtHPmiXKDCxioTUbYsDydjKtFDAzER5eg7OjJWs3V/pub first.
As an alternative, callers can pass an invalid program name using e.g. ProgramName("/invalid"); that's a bit of a hack, but should reliably suppress the unwanted behavior.

@phst phst merged commit f6dd635 into phst:master Jan 17, 2022
phst added a commit that referenced this pull request Jan 17, 2022
After #2, the manifest file always takes
precedence, so this is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manifest-based runfiles lookup is non-hermetic

2 participants