Remove specific configuration for array_fill() with PHP 8#701
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Oct 7, 2021
steevanb:array-fill
Merged
Remove specific configuration for array_fill() with PHP 8#701ondrejmirtes merged 1 commit intophpstan:masterfrom steevanb:array-fill
ondrejmirtes merged 1 commit intophpstan:masterfrom
steevanb:array-fill
Conversation
Member
|
Thank you! /cc @staabm |
Contributor
Author
|
Thanks! Do you know when 0.12.100 will be available with this fix? |
Member
|
There isn't gonna be one. This fix is going to be out with PHPStan 1.0 in a few weeks. |
Contributor
Author
|
Great news, finally the 1.0! Thanks for this awesome tool! |
Member
|
You're welcome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8 allow
array_fill()$start_keyparameter to be less than0, as PHP 7.x does:http://sandbox.onlinephpfunctions.com/code/f41f7ca4e9acd877de048ff3d7905f8d354d99c2
A little difference is: with PHP 7.x if you have a negative number for
$start_index, first index will be your number but next one will be0:http://sandbox.onlinephpfunctions.com/code/f41f7ca4e9acd877de048ff3d7905f8d354d99c2
With PHP 8 it will not be
0but the next number:http://sandbox.onlinephpfunctions.com/code/f41f7ca4e9acd877de048ff3d7905f8d354d99c2