Merged
Conversation
06c0768 to
d1c0675
Compare
enumag
commented
Dec 19, 2019
Member
If you want to allow passing
By including the stubs directly in your project first. |
Member
|
I've ran this PR on top of my local branch where I do some basic stub validation. Here are the errors: |
Contributor
Author
Hmm... isn't that always the case? Can you give an example where
Thanks! This is very helpful. |
Member
|
It's not always the case, if you're not careful you can produce a runtime error. See: /**
* @param Collection<Animal> $animalCollection
*/
function addAnimal(Collection $animalCollection): void
{
$collection->add(new Cat()); // this is fine, code does not violate anything
}
/**
* @param Collection<Dog> $dogCollection
*/
function takesDogList(Collection $dogCollection): void
{
addAnimal($dogCollection); // this is not, Cat will be added
} |
Contributor
Author
|
Ok, that explains it a bit. Though I still don't quite understand how to decide which type parameter should be covariant and which shouldn't. 🤔 |
Member
|
I must admit I don't either. But PHPStan can usually point out if the |
Member
|
Turns out the |
5794584 to
5946c81
Compare
Contributor
Author
|
Rebased to master but I don't know how to run the tests to see the errors you reported earlier. When I run phing I'm getting some completely unrelated issues: |
Contributor
Author
|
I fixed the errors you posted but I still don't know what to do with |
Contributor
Author
|
I added the dynamic return type extension. I tested it on my project and it seems to work fine. |
Contributor
Author
|
In my project when I put |
Member
|
Hi, the build is failing, please fix it: https://travis-ci.org/phpstan/phpstan-src/jobs/631809338?utm_medium=notification&utm_source=github_status It's not ideal to run the build on PHP 7.4. PHPStan supports it, but Phing outputs some deprecated warnings and PHPCS is completely skipped. |
Member
|
If PHPStan isn't reporting anything, template-covariant should be fine. |
5c273fe to
8301008
Compare
Contributor
Author
|
Coding style should be fixed now. Changed everything to |
Contributor
Author
|
Build is failing because the ds extension is missing on travis so we need to add it using |
Member
|
The extension isn’t necessary for anything, the code doesn’t depend on it. Why does it fail? (I’m on mobile.) |
Contributor
Author
|
Here is the failure: Since it only reports the Map class, I assume it's because of the |
Contributor
Author
|
This is the issue I think: final class DsMapDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
{
public function getClass(): string
{
return Map::class;
}Maybe I should use |
Member
|
Yes 😊 |
Member
|
There are apparently some errors in the stubs. Please run vendor/bin/phing phpstan locally to see them. (It's possible it's going to be about the covariance.) |
Contributor
Author
|
Well that reported |
Member
|
Looks awesome, thank you! We can course-correct if some problems appear in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #24.
I noticed in existing stubs that you sometimes use
@templateand sometimes@template-covariant. Can you explain the difference to me please?How do I test this on my project now that phpstan is distributed as phar?