Fix: phpdoc cache collision with identical aliases & variable names#471
Merged
ondrejmirtes merged 7 commits intophpstan:masterfrom Mar 13, 2021
Merged
Conversation
68be122 to
b34321b
Compare
Member
|
The build failures might be solvable by bumping the cache version number here: https://github.com/phpstan/phpstan-src/pull/471/files#diff-34511260e902425b48cdc48e7434a8768e633d194e55a1273569d20b8310efceR219 |
Member
|
This line needs to change: |
0f447ca to
f90ef9e
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/** @var Foo $x */in the global scope was cached once for all files, but it can have different semantics depending on the imports used in each file.I can't provide a playground link because the bug requires multiple files. Please see the test coverage I added for an example.