Fix XMLReader::open() return type#456
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Mar 17, 2021
Merged
Conversation
Member
This is possible with dynamic return type extensions: https://phpstan.org/developing-extensions/dynamic-return-type-extensions so feel free to contribute one :) There are many examples to learn from in PHPStan's codebase itself: https://github.com/phpstan/phpstan-src/tree/master/src/Type/Php |
c928740 to
21e042f
Compare
Contributor
Author
|
@ondrejmirtes, I found some time to add a dynamic return type extension for |
Member
|
Thank you |
1 task
This was referenced Jun 6, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLReader::open() returns an instance of
XMLReaderwhen called statically (and according to itsReflectionMethod,XMLReader::open()is actually a static function).Currently, this method is now unable to use in boths ways without PHPStan reporting errors with strict rules enabled:
Actually, an even better fix would be to make the return type dependent on whether the method is called statically or not, is that possible? It returns
XMLReader|falsewhen called statically orboolwhen called non-statically.