Fix RedisCluster::multi() return type#4283
Merged
ondrejmirtes merged 3 commits intophpstan:2.1.xfrom Sep 4, 2025
Merged
Conversation
4f2c1e1 to
6b77717
Compare
6b77717 to
c74a5d6
Compare
ondrejmirtes
requested changes
Sep 4, 2025
| \PHPStan\dumpType($redisCluster); | ||
|
|
||
| $transaction = $redisCluster->multi(); | ||
| \PHPStan\dumpType($transaction); |
Member
There was a problem hiding this comment.
Instead of this, use assertType function and put this under tests/PHPStan/Analyser/nsrt. That's the usual place for type inference tests.
ondrejmirtes
requested changes
Sep 4, 2025
| public function testBug13392(): void | ||
| { | ||
| $errors = $this->runAnalyse(__DIR__ . '/nsrt/bug-13392.php'); | ||
| $this->assertNoErrors($errors); |
Member
There was a problem hiding this comment.
No need to have this here. The file will be picked up automatically by NodeScopeResolverTest.
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
RedisCluster::multi()incorrectly returnedRedis.While fixing this issue, I noticed that some other return types in
RedisClusterdiffer from the latest official stubs.Should I open a separate PR to address these discrepancies?
resolve phpstan/phpstan#13392