This pull request has been marked as ready for review.

I feel like we'd need a similar fix for Scope manipulation in NodeScopeResolver. There this situation is detected by instanceof ErrorType which sometimes fails.

Try adding assertType tests around this code.

Try adding assertType tests around this code.

Added.

We get,

assertType('mixed', $data);
$data[] = 1;
assertType('mixed', $data);

function (): void {
	assertType('*ERROR*', $data);
	$data[] = 1;
	assertType('array{1}', $data);
};

We should get rid of instanceof ErrorType in NodeScopeResolver. It leads to these problems: https://phpstan.org/r/a2ab0fbe-4741-4ab3-8d8e-51d9d29a91ac

And regarding:

We get,

That's perfect! 👍

We should get rid of instanceof ErrorType in NodeScopeResolver. It leads to these problems: phpstan.org/r/a2ab0fbe-4741-4ab3-8d8e-51d9d29a91ac

I get

$a = $foo->doFoo();
		assertType('*ERROR*', $a);
		$a[] = 5;
		assertType('mixed', $a);

now

Look at the issue bot, this also fixes phpstan/phpstan#7286 (your issue) and also maybe phpstan/phpstan#3803. Please add regression tests for them.

Look at the issue bot, this also fixes phpstan/phpstan#7286 (your issue) and also maybe phpstan/phpstan#3803. Please add regression tests for them.

Indeed, both are fixed. Nice, I added two non regressions tests then.

Thank you.