Fix function signatures for preg_replace_callback[_array] for PHP 7.4+#411
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Dec 21, 2020
Merged
Conversation
Member
|
Hi, can you show me a false positive on phpstan.org, so we can verify this fix? Thank you. |
Contributor
Author
|
Hi @ondrejmirtes. This code should do for an example: <?php declare(strict_types = 1);
class HelloWorld
{
public function somePregReplaceCallbackExample(): ?string
{
return \preg_replace_callback(
'#example(\w+)?#',
fn ($matches) => $matches[1] ? ': $1' : '',
'example',
-1,
$count,
\PREG_UNMATCHED_AS_NULL,
);
}
}Result on the PHPStan Playground:
|
Member
|
Hi, the playground has Share button. Please post the link to it. Thanks. |
Contributor
Author
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current function signatures for
preg_replace_callbackandpreg_replace_callback_arraydo not include the$flagsargument introduced in PHP 7.4 (see https://www.php.net/manual/en/function.preg-replace-callback.php and https://www.php.net/manual/en/function.preg-replace-callback-array.php). This pull request should (hopefully) fix that.