Support iterable as template type#3984
Merged
ondrejmirtes merged 1 commit intophpstan:1.12.xfrom May 13, 2025
Merged
Conversation
Contributor
Author
|
Static analysis error is in line with other (baselined) errors for which I followed the same logic. So probably irrelevant (/can be baselined, not sure if I'm expected to do that or it happens automatically one way or another after / during merging). Furthermore locally I also get errors in |
Member
Thanks! |
36ea0e7 to
8108ddd
Compare
Contributor
Author
|
Updated and tested a merge upwards again. Sadly though it still results in a conflict. This time in the baseline (if I'm seeing it correctly due to the quote change ( |
Member
|
Baseline is fine, I can regenerate that. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#12214
Note: I'm targeting 1.12 branch. But I'm not sure whether that is allowed (in this instance). But I tested merging upwards and that seems to work fine (-ish, just a merge conflict with the added unit test methods as more methods are added in the test class).