Use ReturnTypeExtension for mb_str_split#379
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Nov 26, 2020
Merged
Conversation
ondrejmirtes
requested changes
Nov 23, 2020
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
And a test. See where str_split is already tested.
95660e6 to
da9c97e
Compare
da9c97e to
dd0d4fa
Compare
Contributor
Author
|
@ondrejmirtes The PR seems fine to me now. But all the test are failing weirdly. |
Member
|
Thank you! |
Member
|
I fixed the CI with: ef6ca4a Something weird is going on with latest version of nette/di... |
Contributor
Author
Thanks you too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't
mb_str_splitwork asstr_split? @ondrejmirtesI can add tests if you think it's right.