Retain list type when assigning to offset 1 of non-empty-list#3682
Merged
ondrejmirtes merged 3 commits intophpstan:1.12.xfrom Nov 27, 2024
Merged
Retain list type when assigning to offset 1 of non-empty-list#3682ondrejmirtes merged 3 commits intophpstan:1.12.xfrom
ondrejmirtes merged 3 commits intophpstan:1.12.xfrom
Conversation
cb52ced to
5570289
Compare
staabm
reviewed
Nov 27, 2024
Member
|
Thank you. |
herndlm
commented
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#12131
I don't think we can detect this edge case inside
Type::setOffsetValueType()because we need info of 2 different accessory types, right? IsIntersectionTypethe best place then I suppose?