Skip to content

Fixed Redis::zScore() signature#319

Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom
lyrixx:redis
Sep 9, 2020
Merged

Fixed Redis::zScore() signature#319
ondrejmirtes merged 2 commits intophpstan:masterfrom
lyrixx:redis

Conversation

@lyrixx
Copy link
Copy Markdown
Contributor

@lyrixx lyrixx commented Sep 9, 2020

@ondrejmirtes
Copy link
Copy Markdown
Member

So can it ever be true? If not then the type should be float|false.

@lyrixx
Copy link
Copy Markdown
Contributor Author

lyrixx commented Sep 9, 2020

Good catch, fixed

@lyrixx lyrixx changed the title Fixed Reis::zScore() signature Fixed Redis::zScore() signature Sep 9, 2020
@ondrejmirtes ondrejmirtes merged commit c7a674d into phpstan:master Sep 9, 2020
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@lyrixx lyrixx deleted the redis branch September 9, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants