Add option to check internal class capitalization#313
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Sep 1, 2020
Riimu:add-internal-class-case-check
Merged
Add option to check internal class capitalization#313ondrejmirtes merged 1 commit intophpstan:masterfrom Riimu:add-internal-class-case-check
ondrejmirtes merged 1 commit intophpstan:masterfrom
Riimu:add-internal-class-case-check
Conversation
Member
|
Flawless contribution ❤️ |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently PHPStan has option
checkFunctionNameCasewhich checks the case sensitivity of function names in code. This checks the cases of both user defined and built in PHP functions.PHPStan also has an option
checkClassCaseSensitivity, but that option does not check the capitalization of built in classes. The reasoning for this is that using internal classes with incorrect capitalization does not actually result in bugs, but usage of user defined classes can result in bugs especially due to class loader behavior.This PR adds a new option
checkInternalClassCaseSensitivitywhich, when enabled, also checks the capitalization of internal classes for consistency.