Support @phan- prefixes on recognized phpdoc tags#3000
Support @phan- prefixes on recognized phpdoc tags#3000ondrejmirtes merged 4 commits intophpstan:1.11.xfrom
@phan- prefixes on recognized phpdoc tags#3000Conversation
|
The implementation is wrong. You should test what happens which prefix has priority if more of them are present. @phpstan- should always win. |
|
I just copied what seemed to be being done for As I mentioned, feel free to update the PR. Or, if you want to point out specific test cases where |
…tan-` in case order matters
ondrejmirtes
left a comment
There was a problem hiding this comment.
InvalidPhpDocTagValueRule needs to ignore @phan- tags, same as it ignores @psalm-.
|
Thanks a lot! |
Per request at phpstan/phpdoc-parser#235 (comment)
Hopefully I added the right tests in the right places, mostly I grepped for "psalm" then tried to add similar tests. Feel free to update the PR if necessary.