Use str_starts_with() and str_contains() instead of strpos()#2841
Merged
ondrejmirtes merged 1 commit intophpstan:1.10.xfrom Dec 30, 2023
Merged
Conversation
aafd9c5 to
0918b73
Compare
0918b73 to
6261d1a
Compare
Member
|
Thank you! Yes, I prefer this, but to be clear, this is enabled only thanks to the fact that PHPStan includes Symfony polyfills :) But on newer PHP versions the native functions will be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These codes have been clarified by replacing them with functions introduced in PHP 8.x, and are only slightly micro-optimized.