Skip to content

PDO::exec could also return false#281

Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom
Slamdunk:patch-1
Jul 22, 2020
Merged

PDO::exec could also return false#281
ondrejmirtes merged 1 commit intophpstan:masterfrom
Slamdunk:patch-1

Conversation

@Slamdunk
Copy link
Copy Markdown
Contributor

@ondrejmirtes
Copy link
Copy Markdown
Member

So when it actually returns false? Does it depend on the PDO error mode?

@Slamdunk
Copy link
Copy Markdown
Contributor Author

As far as I can tell from php-src, when statement is an empty string or a driver error occurs like https://github.com/php/php-src/blob/c85ded763222295f9d24f8550b9428259bc36e86/ext/pdo_mysql/mysql_driver.c#L259

@ondrejmirtes
Copy link
Copy Markdown
Member

Alright, thank you!

@ondrejmirtes ondrejmirtes merged commit 262694d into phpstan:master Jul 22, 2020
@Slamdunk Slamdunk deleted the patch-1 branch July 22, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants