Merged
Conversation
ondrejmirtes
requested changes
Nov 26, 2023
resources/functionMap.php
Outdated
Member
There was a problem hiding this comment.
Parameters don't need to be renamed
resources/functionMap.php
Outdated
Member
There was a problem hiding this comment.
What effect should this have? The types aren't enforced: https://phpstan.org/r/25c3b187-4888-4aa4-86ad-5e350f16346f
Contributor
Author
There was a problem hiding this comment.
I see, it turns out that typing like @param-out cannot be solved by modifying only the functionMap.
https://phpstan.org/r/3c7a8a08-abce-45c9-b310-0bcb4e4b6ba4
The execution results of the function are as follows:
076bb7b to
6b3f805
Compare
6b3f805 to
046ea30
Compare
49433f2 to
fff2584
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.