Skip to content

Make extensions that return default types simply return null;#2782

Merged
ondrejmirtes merged 2 commits intophpstan:1.10.xfrom
zonuexe:refactor/return-type-extension-returns-null
Nov 26, 2023
Merged

Make extensions that return default types simply return null;#2782
ondrejmirtes merged 2 commits intophpstan:1.10.xfrom
zonuexe:refactor/return-type-extension-returns-null

Conversation

@zonuexe
Copy link
Copy Markdown
Contributor

@zonuexe zonuexe commented Nov 26, 2023

Prevent copy-pasting by referencing existing extensions by simply replacing it with return null;.

refs #2776 (comment)

@phpstan-bot
Copy link
Copy Markdown
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@zonuexe zonuexe changed the base branch from 1.11.x to 1.10.x November 26, 2023 17:34
@ondrejmirtes ondrejmirtes merged commit e0ad408 into phpstan:1.10.x Nov 26, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you.

@zonuexe zonuexe deleted the refactor/return-type-extension-returns-null branch November 26, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants