Skip to content

Added PHPSTAN_FAIL_WITHOUT_RESULT_CACHE env var#2611

Merged
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
staabm:fail-if-no-result-cache
Sep 8, 2023
Merged

Added PHPSTAN_FAIL_WITHOUT_RESULT_CACHE env var#2611
ondrejmirtes merged 5 commits intophpstan:1.10.xfrom
staabm:fail-if-no-result-cache

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Sep 8, 2023 •
edited
Loading

to allow testing of the result-cache lets add a new env var a new cli option, which we can use to instruct phpstan to exit with code=2, when the result cache was not used

see phpstan/phpstan#9857 (comment)

partly reverts #2608

➜  bug8778 git:(bug8778) ../../phpstan clear-result-cache -q; ../../phpstan analyse -q                                            
➜  bug8778 git:(bug8778) ../../../phpstan-src/bin/phpstan analyse -vvv --generate-baseline --fail-without-result-cache
Note: Using configuration file /Users/staabm/workspace/phpstan/e2e/bug8778/phpstan.neon.
Result cache not used because the metadata do not match.
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%  1 sec/1 sec 

Result cache is saved.

                                                                                                                        
 [OK] Baseline generated with 1 error.                                                                                  
                                                                                                                        

Used memory: 78 MB
➜  bug8778 git:(bug8778) echo $?
2

staabm added a commit to staabm/phpstan that referenced this pull request Sep 8, 2023
@staabm
use env var for testing
9c84939 
requires phpstan/phpstan-src#2611
@staabm staabm mentioned this pull request Sep 8, 2023
Merged
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 8, 2023

I agree that the error formatter was the wrong direction. But instead of env variable, I'd prefer --fail-without-result-cache CLI option :)

@staabm
Copy link
Contributor Author

staabm commented Sep 8, 2023

here you are

➜  bug8778 git:(bug8778) ../../phpstan clear-result-cache -q; ../../phpstan analyse -q                                            
➜  bug8778 git:(bug8778) ../../../phpstan-src/bin/phpstan analyse -vvv --generate-baseline --fail-without-result-cache
Note: Using configuration file /Users/staabm/workspace/phpstan/e2e/bug8778/phpstan.neon.
Result cache not used because the metadata do not match.
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%  1 sec/1 sec 

Result cache is saved.

                                                                                                                        
 [OK] Baseline generated with 1 error.                                                                                  
                                                                                                                        

Used memory: 78 MB
➜  bug8778 git:(bug8778) echo $?
2

@ondrejmirtes ondrejmirtes merged commit 2cb2f07 into phpstan:1.10.x Sep 8, 2023
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 8, 2023

Thank you.

@staabm staabm deleted the fail-if-no-result-cache branch September 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes