openssl_pkey_export() allows null for the passphrase#256
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Jun 24, 2020
Merged
openssl_pkey_export() allows null for the passphrase#256ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
Member
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was originally discussed here: fastsitephp/fastsitephp#20 (comment)
Basically, PHP Docs shows that
openssl_pkey_export()andopenssl_pkey_export_to_file()use string type for thepassphraseparameter while a review of PHP Source Code https://github.com/php/php-src/ shows that both strings and null are used and supported.This was found when originally changing
nullto an empty string''for PHPStan causes multiple unit tests to break in a project which uses PHPStan.