Constant arrays without an explicit class string should not resolve#231
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Jun 10, 2020
Merged
Constant arrays without an explicit class string should not resolve#231ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
Member
|
Perfect, thank you! Can you test dev-master once it builds in 10-15 minutes to verify this fixes your issue, or that there's another path we need to fix? Thanks :) |
Contributor
Author
|
I already ran this change against our code and the errors are no more! :) Thanks for the quick feedback on this issue and the PR! |
Member
|
Alright :) With the current cadence of bugfixes i expect this to be released in 1-2 days :) |
Member
|
Oops, merged too soon, can you send a PR that fixes these failures? :) Thanks: https://github.com/phpstan/phpstan-src/runs/756749503?check_suite_focus=true |
Contributor
Author
|
I noticed the builds failing, but it will be a few hours before I can fix this, sorry. |
Member
|
I'll have to look into those failures, we probably created a BC break which will need to be solved. |
rainbow-alex
added a commit
to rainbow-alex/phpstan-src
that referenced
this pull request
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the class name.
Fixes phpstan/phpstan#3428