Specify never for array_combine with different number of elements#2303
Specify never for array_combine with different number of elements#2303ondrejmirtes merged 1 commit intophpstan:1.10.xfrom
never for array_combine with different number of elements#2303Conversation
f26e05f to
c81a308
Compare
|
Thanks for working on it. I think we need another test which shows a actual useful rule error. The never type alone might not create a useful error |
d5e1be7 to
7984aea
Compare
|
not sure if this really needs another rule test? It feels not much related to me, but what were you thinking of, a rule that reports that this always throws an exception or smth like that? is this even existing already? Everything else I can think of is maybe not really related to |
|
my thinking is that a in-detail change like this is not really useful, when we don't know how it fits in the bigger picture (so which errors are generated because of this change and whether these are useful for a particular use-case) |
7984aea to
73cd7b8
Compare
|
I think this one's a tiny change that fixes a bug and is good to go, or does anybody have any better ideas about more tests? @ondrejmirtes |
|
Thank you. |
Was found by @gnutix in phpstan/phpstan#9011 (comment)
CC @staabm