Skip to content

Implement php version dependent loose const comparison#2220

Merged
ondrejmirtes merged 4 commits intophpstan:1.10.xfrom
staabm:loose-constants
Feb 6, 2023
Merged

Implement php version dependent loose const comparison#2220
ondrejmirtes merged 4 commits intophpstan:1.10.xfrom
staabm:loose-constants

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Feb 5, 2023 •
edited
Loading

@staabm staabm mentioned this pull request Feb 5, 2023
Draft
@staabm staabm force-pushed the loose-constants branch 3 times, most recently from 48fb829 to 81386b6 Compare February 5, 2023 11:23
staabm
staabm commented Feb 5, 2023
View reviewed changes
@staabm staabm force-pushed the loose-constants branch 2 times, most recently from 0c903fc to af13974 Compare February 5, 2023 12:56
ondrejmirtes
ondrejmirtes requested changes Feb 6, 2023
View reviewed changes
@staabm staabm marked this pull request as ready for review February 6, 2023 11:40
@phpstan-bot
Copy link
Copy Markdown
Collaborator

phpstan-bot commented Feb 6, 2023

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit d5d396d into phpstan:1.10.x Feb 6, 2023
@ondrejmirtes
Copy link
Copy Markdown
Member

ondrejmirtes commented Feb 6, 2023

Thank you.

@staabm staabm deleted the loose-constants branch February 6, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@staabm @phpstan-bot @ondrejmirtes