Fix hasSideEffects for AnnotationMethodReflection#2155
Merged
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom Dec 31, 2022
Merged
Fix hasSideEffects for AnnotationMethodReflection#2155ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
Conversation
acd1c61 to
945e287
Compare
VincentLanglet
commented
Dec 30, 2022
ondrejmirtes
requested changes
Dec 30, 2022
| public function hasSideEffects(): TrinaryLogic | ||
| { | ||
| if ( | ||
| strtolower($this->getName()) !== '__construct' |
Member
There was a problem hiding this comment.
I think you can delete the thing about __construct.
228610f to
9c623c9
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to phpstan/phpstan#8586 (reply in thread)